Fix typo in Rust tree traversal #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation Edit
Gathros
requested changes
Aug 5, 2018
| println!("Recursive DFS BTree:"); | ||
| dfs_recursive_inorder_btree(&root); | ||
| println!("Recursive in-order DFS BTree:"); | ||
| let root_binary = create_tree(3, 2); |
There was a problem hiding this comment.
Why not just have one tree.
There was a problem hiding this comment.
If you want to test the in-order, you need a binary tree. The other tree is ternary.
There was a problem hiding this comment.
Just keep the other tree binary too.
There was a problem hiding this comment.
The Julia code and chapter show examples with ternary, though. Not a big deal to me, but I'm not actually reviewing the code, just answering one question :)
There was a problem hiding this comment.
You're right it, should match the julia code.
Gathros
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating trees is also more consistent with the Julia implementation.